doc: revise Collaborator description in GOVERNANCE.md by Trott · Pull Request #27071 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Active voice
Remove Node.js Foundation mention. It may be appropriate to add
something back in when the new foundation is bootstrapped. We
don't control membership criteria, so best to link to something else
when it becomes available rather than make guarantees in this doc.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Active voice
Remove Node.js Foundation mention. It may be appropriate to add something back in when the new foundation is bootstrapped. We don't control membership criteria, so best to link to something else when it becomes available rather than make guarantees in this doc.

Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added a commit to Trott/io.js that referenced this pull request

Apr 5, 2019

Active voice
Remove Node.js Foundation mention. It may be appropriate to add something back in when the new foundation is bootstrapped. We don't control membership criteria, so best to link to something else when it becomes available rather than make guarantees in this doc.

PR-URL: nodejs#27071 Reviewed-By: Anto Aravinth anto.aravinth.cse@gmail.com Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yuta Hiroto hello@hiroppy.me Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

This was referenced

Apr 23, 2019

Trott deleted the gov-revise branch

January 13, 2022 22:51

Reviewers

jasnell jasnell approved these changes