src: unify crypto constant setup by sam-github · Pull Request #27077 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

DefineCryptoConstants() sets constants from OpenSSL into
crypto.constants, for crypto and tls. DefineOpenSSLConstants() did
exactly the same. Unify them.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot added the c++

Issues and PRs that require attention from people who are familiar with C++.

label

Apr 3, 2019

DefineCryptoConstants() sets constants from OpenSSL into crypto.constants, for crypto and tls. DefineOpenSSLConstants() did exactly the same. Unify them.

11:47:56   Generating code
11:47:56 c:\workspace\node-compile-windows\src\node_main.cc : fatal error C1382: the PCH file 'c:\workspace\node-compile-windows\release\obj\node\node.pch' has been rebuilt since 'c:\workspace\node-compile-windows\release\obj\node\node_main.obj' was generated. Please rebuild this object [c:\workspace\node-compile-windows\node.vcxproj]
11:47:56 LINK : fatal error LNK1257: code generation failed [c:\workspace\node-compile-windows\node.vcxproj]

That's odd, the build failed on https://ci.nodejs.org/job/node-compile-windows/25743/label=win-vs2017-x86/console

I resumed.

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 4, 2019

@Trott Yes, I see the same thing. Its not clear if something was changed to fix it, but this just passed on Windows, too.

Yay?

sam-github added a commit that referenced this pull request

Apr 8, 2019

DefineCryptoConstants() sets constants from OpenSSL into crypto.constants, for crypto and tls. DefineOpenSSLConstants() did exactly the same. Unify them.

PR-URL: #27077 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Daniel Bevenius daniel.bevenius@gmail.com Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

This was referenced

Apr 23, 2019

This was referenced

Apr 23, 2019

Reviewers

addaleax addaleax approved these changes