doc: link bigint type to MDN instead of proposal by vsemozhetbyt · Pull Request #27101 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

It is not an ideal solution yet: bigint as a new primitive currently absent in the MDN section we usually link primitives to, so we need to refer to a global object which may be a bit confusing. But maybe this is better than to link to the proposal now.

nodejs-github-bot added doc

Issues and PRs related to the documentations.

tools

Issues and PRs related to the tools directory.

labels

Apr 5, 2019

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 5, 2019

Landed in 1afec97
Thank you for the reviews.

vsemozhetbyt added a commit that referenced this pull request

Apr 7, 2019

PR-URL: #27101 Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

This was referenced

Apr 23, 2019

Reviewers

jasnell jasnell approved these changes