stream: remove dead code by marcosc90 · Pull Request #27125 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Removed unreachable code. In line 511, state.ended is set to true. So process.nextTick(emitReadable_, stream); can't be reached.

Remove unreachable code. state.ended is always set to true in this part of the code. The else clause can't be executed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CITGM

ZYSzys added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 8, 2019

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request

Apr 10, 2019

Remove unreachable code. state.ended is always set to true in this part of the code. The else clause can't be executed.

PR-URL: nodejs#27125 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Tobias Nießen tniessen@tnie.de