console: remove trace frame by BridgeAR · Pull Request #27159 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

The own function's frame was removed originally. This restors that
behavior.

Fixes: #27134

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

The own function's frame was removed originally. This restors that behavior.

Fixes: nodejs#27134

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message has a typo (restors).

@@ -330,13 +330,13 @@ const consoleMethods = {
trace(kTraceInstant, kTraceConsoleCategory, `time::${label}`, 0);
},

trace(...args) {
trace: function trace(...args) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this strictly needed? I thought the shorthand notation had the same behavior.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the shorthand notation, the function would be called as obj.property. It is not possible to access the function itself by only using the property name. That is only possible inside the old function foo type.

It would also be possible if this would not be a property but a variable.

BridgeAR added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 10, 2019

targos pushed a commit to targos/node that referenced this pull request

Apr 12, 2019

The own function's frame was removed originally. This restors that behavior.

Fixes: nodejs#27134

PR-URL: nodejs#27159 Reviewed-By: Eugene Ostroukhov eostroukhov@google.com Reviewed-By: Richard Lau riclau@uk.ibm.com Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Сковорода Никита Андреевич chalkerx@gmail.com

This was referenced

Apr 23, 2019

BridgeAR deleted the remove-extra-trace-line branch

January 20, 2020 12:02

Reviewers

eugeneo eugeneo approved these changes