src: make a Environment-independent proxy class for NativeModuleLoader by joyeecheung · Pull Request #27160 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This patch splits NativeModuleLoader into two parts - a singleton
that only relies on v8 and node::Mutex and a proxy class for
the singleton (NativeModuleEnv) that provides limited access to
the singleton as well as C++ bindings for the Node.js binary.NativeModuleLoader is then no longer aware of Environment.
This is split out of #27135
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes- commit message follows commit guidelines
Issues and PRs that require attention from people who are familiar with C++.
Issues and PRs related to general changes in the lib or src directory.
labels
@nodejs/process @nodejs/build-files This needs one more review to land - I hope to land this soon so that #27135 can be unblocked.
This patch splits NativeModuleLoader into two parts - a singleton
that only relies on v8 and node::Mutex and a proxy class for
the singleton (NativeModuleEnv) that provides limited access to
the singleton as well as C++ bindings for the Node.js binary.
NativeModuleLoader is then no longer aware of Environment.
joyeecheung added a commit to joyeecheung/node that referenced this pull request
This patch splits NativeModuleLoader into two parts - a singleton
that only relies on v8 and node::Mutex and a proxy class for
the singleton (NativeModuleEnv) that provides limited access to
the singleton as well as C++ bindings for the Node.js binary.
NativeModuleLoader is then no longer aware of Environment.
PR-URL: nodejs#27160 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Richard Lau riclau@uk.ibm.com
This was referenced
Apr 23, 2019
Labels
PRs that have at least one approval, no pending requests for changes, and a CI started.
Issues and PRs that require attention from people who are familiar with C++.
Issues and PRs related to general changes in the lib or src directory.