test: optimize total Travis run time by refack · Pull Request #27182 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation20 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

skip compilation by using cache
split testing into two jobs
DRY with YAML anchors

Refs: #27158

~~Eliminates the stages; they are unnecessary for a typical CI run, and extend the run time by at least 3.5 minutes.~~
Instead of eliminating the compile stage it now caches the binary so the test stage doesn't need to bootstrap the compiler and doesn't need to recompile.

/CC @nodejs/testing @nodejs/build-files @nodejs/python

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

nodejs-github-bot added build

Issues and PRs related to build files or the CI.

test

Issues and PRs related to the tests.

tools

Issues and PRs related to the tools directory.

labels

Apr 10, 2019

This configuration can potentially finish in 6 + 5 minutes 🚀

P.S. Success

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Ab)using the ccache to transfer binaries between compile and test jobs ✔️💡.

Try to cut down the total time for a Travis CI sanity test.

Eliminates the stages; they are unnecessary for a typical CI run, and extend the run time by at least 3.5 minutes.
For PRs that change V8, the first successful run of "Compile V8" will hydrate the cache, so subsequent runs should complete in < 50 minutes

Maybe update the OP? Stages haven't been eliminated.

Travis run now covers addons as well. minimal time approx 4(compile) + 5.5(test) minutes.

@nodejs/testing @nodejs/build-files PTAL

Current master: