test: remove flaky designation for test-cli-node-options by Trott · Pull Request #27305 · nodejs/node (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

The test failure is not platform-specific and is the result of
manual/human error. Some improvements may be possible, but there is
nothing fundamentally unsound about the test insofar as when it fails in
CI, there is a problem on the host that needs to be addressed and not an
inherent issue with the test.

Refs: #25028 (comment)
Closes: #25028

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

The test failure is not platform-specific and is the result of manual/human error. Some improvements may be possible, but there is nothing fundamentally unsound about the test insofar as when it fails in CI, there is a problem on the host that needs to be addressed and not an inherent issue with the test.

Refs: nodejs#25028 (comment) Closes: nodejs#25028

Trott added the author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

label

Apr 19, 2019

Trott added a commit to Trott/io.js that referenced this pull request

Apr 21, 2019

The test failure is not platform-specific and is the result of manual/human error. Some improvements may be possible, but there is nothing fundamentally unsound about the test insofar as when it fails in CI, there is a problem on the host that needs to be addressed and not an inherent issue with the test.

Refs: nodejs#25028 (comment) Closes: nodejs#25028

PR-URL: nodejs#27305 Fixes: nodejs#25028 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Colin Ihrig cjihrig@gmail.com

This was referenced

Apr 23, 2019

Trott deleted the rm-non-flaky branch

January 13, 2022 22:51

Labels

author ready

PRs that have at least one approval, no pending requests for changes, and a CI started.

test

Issues and PRs related to the tests.