util: make inspect more reliable by evanlucas · Pull Request #4098 · nodejs/node (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
34a3591 added pretty printing for
TypedArray, ArrayBuffer, and DataView. This change allows inspecting
those across different contexts.
Since instanceof does not work across contexts, we can use
v8::Value::IsTypedArray, v8::Value::IsArrayBuffer, and
v8::Value::IsDataView
/cc @bnoordhuis
Issues and PRs related to the built-in util module.
label
Will land tomorrow if there are no objections. Thanks!
34a3591 added pretty printing for TypedArray, ArrayBuffer, and DataView. This change allows inspecting those across different contexts.
Since instanceof does not work across contexts, we can use v8::Value::IsTypedArray, v8::Value::IsArrayBuffer, and v8::Value::IsDataView
PR-URL: nodejs#4098 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
I'm going to add semver-major because its dependency, 34a3591 / #3793, is tagged as semver-major and we need to keep them both off v5.x, I'm also going to remove lts-watch-v4.x.
I'm not convinced that 34a3591 should be semver-major but that's a discussion for #3793.
/cc @bnoordhuis
Note on semver-major: I think a case could be made that this is semver-major on its own, but I'd really just like the clarity that this is tied to another semver-major and therefore needs to stay out of backports, we could possibly remove the tag before pushing 6.0.0 out if we want to keep that out of the release notes. Perhaps another label would be helpful for these semver edge-cases? Same applies to the (node:pid) logging changes, there's a bunch of them together with only the first one being labelled semver-major.
scovetta pushed a commit to scovetta/node that referenced this pull request
34a3591 added pretty printing for TypedArray, ArrayBuffer, and DataView. This change allows inspecting those across different contexts.
Since instanceof does not work across contexts, we can use v8::Value::IsTypedArray, v8::Value::IsArrayBuffer, and v8::Value::IsDataView
PR-URL: nodejs#4098 Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Labels
PRs that contain breaking changes and should be released in the next major version.
Issues and PRs related to the built-in util module.