fix: keep idle validation on global timers by mcollina · Pull Request #5407 · nodejs/undici (original) (raw)

Skip to content

Navigation Menu

• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

mcollina

merged 1 commit into

Jun 10, 2026

Conversation

Summary

• restore idle socket validation to use the normal global timer APIs instead of bypassing fake timers through node:timers
• update cache interceptor tests to fake only Date, which is the only clock behavior they need to control
• keep the poisoned idle socket test synchronization from fix: keep idle validation on native timers #5397

Tests

• node --test test/interceptors/cache.js
• node --test test/response-queue-poisoning.js test/issue-810.js
• npm run lint -- --quiet

Signed-off-by: Matteo Collina hello@matteocollina.com

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.24%. Comparing base (b4c287b) to head (9290322).

Additional details and impacted files

@@ Coverage Diff @@ ## main #5407 +/- ##

• Coverage 93.25% 93.24% -0.01%

  Files 110 110
  Lines 36826 36825 -1

• Hits 34341 34337 -4
• Misses 2485 2488 +3

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})