align EventSource with spec by KhafraDev · Pull Request #5418 · nodejs/undici (original) (raw)
Claude, find a bug in undici then create an issue to waste maintainer's time
fixes #5378
(afaik there's no discernible behavior differences, so can't really write a test)
Codecov Report
❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.35%. Comparing base (0d6ecc5) to head (2493c53).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| lib/web/eventsource/util.js | 93.75% | 2 Missing ⚠️ |
Additional details and impacted files
@@ Coverage Diff @@ ## main #5418 +/- ##
Coverage 93.35% 93.35% -0.01%
Files 110 110
Lines 36928 36949 +21
- Hits 34475 34494 +19
- Misses 2453 2455 +2
☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
if there is no difference why should we land this?
so we don't get more ai created issues that mention this as a bug
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})