Use the XAJavaInterop1 codegen by default by Redth · Pull Request #189 · novotnyllc/MSBuildSdkExtras (original) (raw)

Redth commented

Oct 7, 2019

Copy link Copy Markdown

Contributor

See: https://docs.microsoft.com/en-us/xamarin/android/deploy-test/building-apps/build-process#binding-project-build-properties

Basically, smaller, faster bindings - this does require 6.1 or later, so there's a condition for that.

This also bumps TargetFrameworkVersion to something a bit more sane (really I'd like to see this go to 9.0)

`` [Use the XAJavaInterop1 codegen by default](/novotnyllc/MSBuildSdkExtras/pull/189/commits/4cde5ff36db491c0f449f5185808ebc0c5d5fcc9 "Use the XAJavaInterop1 codegen by default

See: https://docs.microsoft.com/en-us/xamarin/android/deploy-test/building-apps/build-process#binding-project-build-properties

Basically, smaller, faster bindings - this does require 6.1 or later, so there's a condition for that.

This also bumps TargetFrameworkVersion to something a bit more sane (really I'd like to see this go to 9.0)") ``

[4cde5ff](/novotnyllc/MSBuildSdkExtras/pull/189/commits/4cde5ff36db491c0f449f5185808ebc0c5d5fcc9)

See: https://docs.microsoft.com/en-us/xamarin/android/deploy-test/building-apps/build-process#binding-project-build-properties

Basically, smaller, faster bindings - this does require 6.1 or later, so there's a condition for that.

This also bumps TargetFrameworkVersion to something a bit more sane (really I'd like to see this go to 9.0)

clairernovotny commented

Oct 7, 2019

Copy link Copy Markdown

Collaborator

Thanks!

For the min version, keep in mind that only applies if someone specifies MonoAndroid. If they put in a version, like MonoAndroid80 or MonoAndroid9, that'll always win.

clairernovotny merged commit adce315 into novotnyllc:master

Oct 7, 2019

Redth commented

Oct 7, 2019

Copy link Copy Markdown

Contributor Author

Yup, true, just like pushing our users to newer versions of android to target, especially now that Google is enforcing this more strictly in the play store.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment