fix: scope config by ruyadorno · Pull Request #1758 · npm/cli (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation0 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@ruyadorno

The flatOptions.scope option should not default to projectScope since that's causing projects that have a defined projectScope corresponding to a configured scoped registry to try and download ALL packages (including the ones that should be downloaded from the public registry) to be fetch from that scoped registry url (as if npm install --scope="@myscope").

This PR fixes it by reinstating a regular flatOptions.scope config.

fix #1654

@ruyadorno

The flatOptions.scope option should not default to projectScope since that's causing projects that have a defined projectScope corresponding to configured scoped registries to try and download ALL packages (including the ones that should be downloaded from the public registry) to be fetch from that scoped registry url.

fix npm#1654

isaacs pushed a commit that referenced this pull request

Sep 4, 2020

@ruyadorno @isaacs

The flatOptions.scope option should not default to projectScope since that's causing projects that have a defined projectScope corresponding to configured scoped registries to try and download ALL packages (including the ones that should be downloaded from the public registry) to be fetch from that scoped registry url.

fix #1654

PR-URL: #1758 Credit: @ruyadorno Close: #1758 Reviewed-by: @isaacs

Labels

Bug

thing that needs fixing

Release 7.x

work is associated with a specific npm 7 release

1 participant

@ruyadorno