fix: npm ls with depth cli config by ruyadorno · Pull Request #1862 · npm/cli (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@ruyadorno

Using the cli option --depth is currently not resulting in the expected
behavior of filtering depth level when running npm ls - that's due
the special behavior of printing all results when using a filter arg.

This commit fixes it by adding support to limiting depth if a config
value is set by the user.

Fixes #1861

ljharb

lib/ls.js Outdated Show resolved Hide resolved

@ruyadorno

Using the cli option --depth is currently not resulting in the expected behavior of filtering depth level when running npm ls - that's due the special behavior of printing all results when using a filter arg.

This commit fixes it by adding support to limiting depth if a config value is set by the user.

Fixes npm#1861

nlf pushed a commit that referenced this pull request

Sep 29, 2020

@ruyadorno @nlf

Using the cli option --depth is currently not resulting in the expected behavior of filtering depth level when running npm ls - that's due the special behavior of printing all results when using a filter arg.

This commit fixes it by adding support to limiting depth if a config value is set by the user.

Fixes #1861

PR-URL: #1862 Credit: @ruyadorno Close: #1862 Reviewed-by: @nlf

nlf pushed a commit that referenced this pull request

Sep 29, 2020

@ruyadorno @nlf

Using the cli option --depth is currently not resulting in the expected behavior of filtering depth level when running npm ls - that's due the special behavior of printing all results when using a filter arg.

This commit fixes it by adding support to limiting depth if a config value is set by the user.

Fixes #1861

PR-URL: #1862 Credit: @ruyadorno Close: #1862 Reviewed-by: @nlf

Labels

Release 7.x

work is associated with a specific npm 7 release