Using array.append(rvalue) will create a copy of rvalue rather than moving it. (original) (raw)

Skip to content

Navigation Menu

Sign in

Appearance settings

• • AI CODE CREATION
    * GitHub CopilotWrite better code with AI
    * GitHub SparkBuild and deploy intelligent apps
    * GitHub ModelsManage and compare prompts
    * MCP RegistryNewIntegrate external tools
  • DEVELOPER WORKFLOWS
    * ActionsAutomate any workflow
    * CodespacesInstant dev environments
    * IssuesPlan and track work
    * Code ReviewManage code changes
  • APPLICATION SECURITY
    * GitHub Advanced SecurityFind and fix vulnerabilities
    * Code securitySecure your code as you build
    * Secret protectionStop leaks before they start
  • EXPLORE
    * Why GitHub
    * Documentation
    * Blog
    * Changelog
    * Marketplace

View all features

• • BY COMPANY SIZE
    * Enterprises
    * Small and medium teams
    * Startups
    * Nonprofits
  • BY USE CASE
    * App Modernization
    * DevSecOps
    * DevOps
    * CI/CD
    * View all use cases
  • BY INDUSTRY
    * Healthcare
    * Financial services
    * Manufacturing
    * Government
    * View all industries

View all solutions

• • EXPLORE BY TOPIC
    * AI
    * Software Development
    * DevOps
    * Security
    * View all topics
  • EXPLORE BY TYPE
    * Customer stories
    * Events & webinars
    * Ebooks & reports
    * Business insights
    * GitHub Skills
  • SUPPORT & SERVICES
    * Documentation
    * Customer support
    * Community forum
    * Trust center
    * Partners
• • COMMUNITY
    * GitHub SponsorsFund open source developers
  • PROGRAMS
    * Security Lab
    * Maintainer Community
    * Accelerator
    * Archive Program
  • REPOSITORIES
    * Topics
    * Trending
    * Collections
• • ENTERPRISE SOLUTIONS
    * Enterprise platformAI-powered developer platform
  • AVAILABLE ADD-ONS
    * GitHub Advanced SecurityEnterprise-grade security features
    * Copilot for BusinessEnterprise-grade AI features
    * Premium SupportEnterprise-grade 24/7 support
• Pricing

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

open-source-parsers / jsoncpp Public

• Notifications You must be signed in to change notification settings

• Fork2.7k

• Star 8.8k

• Code

• Issues 142

• Pull requests 10

• Discussions

• Actions

• Projects

• Wiki

• Security

• Insights

Additional navigation options

New issue

New issue

Closed

Closed

Using array.append(rvalue) will create a copy of rvalue rather than moving it.

#677

Description

rosca

opened

on Sep 15, 2017

Value& Value::append(Value&& value) { return (*this)[size()] = value; }
should become
Value& Value::append(Value&& value) { return (*this)[size()] = std::move(value); }
in order to call the move constructor.

Metadata

Metadata

Assignees

No one assigned

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions