otelconf: add unmarshalers for otlp exporters by codeboten · Pull Request #8112 · open-telemetry/opentelemetry-go-contrib (original) (raw)

Conversation

@codeboten

@codeboten codeboten commented

Oct 31, 2025

Copy link Copy Markdown

Contributor

Adding unmarshalers and tests for otlp http/grpc exporters. Also added a missing test for createHeaders.

Part of splitting #8026

@codeboten

`[otelconf: add unmarshalers for otlp exporters](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/d262f8d4c0b9a891d5fafb5efe0f777cedcd49b0 "otelconf: add unmarshalers for otlp exporters

Adding unmarshalers and tests for otlp http/grpc exporters. Also added a missing test for createHeaders.

Part of splitting #8026

Signed-off-by: alex boten 223565+codeboten@users.noreply.github.com") `

[d262f8d](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/d262f8d4c0b9a891d5fafb5efe0f777cedcd49b0)

Adding unmarshalers and tests for otlp http/grpc exporters. Also added a missing test for createHeaders.

Part of splitting open-telemetry#8026

Signed-off-by: alex boten 223565+codeboten@users.noreply.github.com

@codeboten codeboten requested review froma team and pellared as code owners

October 31, 2025 22:47

codeboten

codeboten commented Oct 31, 2025

View reviewed changes

Comment thread

CHANGELOG.md Outdated

@codeboten

[Update CHANGELOG.md](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/3818c819c07635fc46910638c50dcda5c975ef25 "Update CHANGELOG.md")

[3818c81](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/3818c819c07635fc46910638c50dcda5c975ef25)

@codecov

codecov Bot commented

Oct 31, 2025

edited

Loading

Copy link Copy Markdown

Codecov Report

❌ Patch coverage is 91.66667% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.9%. Comparing base (ccac382) to head (288f130).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
otelconf/config_json.go 88.0% 4 Missing and 4 partials ⚠️
otelconf/config_common.go 66.6% 2 Missing ⚠️

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@ ## main #8112 +/- ##

Files with missing lines Coverage Δ
otelconf/config_yaml.go 98.6% <100.0%> (+0.5%) ⬆️
otelconf/config_common.go 87.5% <66.6%> (+1.7%) ⬆️
otelconf/config_json.go 94.5% <88.0%> (-2.0%) ⬇️

🚀 New features to boost your workflow:

dashpole

dashpole reviewed Nov 3, 2025

View reviewed changes

Comment thread

otelconf/config_json.go

@codeboten

`[fix](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/247bf3b0e64c152d40631f352b0ce913525f9fda "fix

Signed-off-by: alex boten 223565+codeboten@users.noreply.github.com") `

[247bf3b](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/247bf3b0e64c152d40631f352b0ce913525f9fda)

Signed-off-by: alex boten 223565+codeboten@users.noreply.github.com

dashpole

dashpole approved these changes Nov 3, 2025

View reviewed changes

@codeboten

[Merge branch 'main' into codeboten/otelconf-unmarshal-exporters](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/8736c36bb9a35b54438e470130d60361dee88151 "Merge branch 'main' into codeboten/otelconf-unmarshal-exporters")

[8736c36](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/8736c36bb9a35b54438e470130d60361dee88151)

MrAlias

MrAlias approved these changes Nov 3, 2025

View reviewed changes

@MrAlias

[Merge branch 'main' into codeboten/otelconf-unmarshal-exporters](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/288f13072c2df0c03f5abec26704ab5332ef5944 "Merge branch 'main' into codeboten/otelconf-unmarshal-exporters")

[288f130](/open-telemetry/opentelemetry-go-contrib/pull/8112/commits/288f13072c2df0c03f5abec26704ab5332ef5944)

@MrAlias MrAlias merged commit 8d65e49 into open-telemetry:main

Nov 3, 2025

28 checks passed

@MrAlias MrAlias mentioned this pull request

Dec 8, 2025

Release v1.39.0#8261

Merged

@MrAlias MrAlias added this to the v1.39.0 milestone

Dec 8, 2025

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Sign up for free to join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.39.0

Development

Successfully merging this pull request may close these issues.

3 participants

@codeboten @dashpole @MrAlias