instrumentation: update error handling to set attributes instead of recording errors by pellared · Pull Request #8386 · open-telemetry/opentelemetry-go-contrib (original) (raw)

changed the titlefeat(instrumentation): update error handling to set attributes instead of recording errors instrumentation: update error handling to set attributes instead of recording errors

Jan 12, 2026

pellared marked this pull request as ready for review

January 12, 2026 18:12

Eshaan-byte added a commit to Eshaan-byte/opentelemetry-go-contrib that referenced this pull request

Jan 22, 2026

… errors

Fixes open-telemetry#8441

This change updates the error handling in otelgin middleware to follow the instrumentation guidelines established in open-telemetry#8386:

• Replace span.RecordError() calls with span.SetAttributes(ErrorType())
• Set error.type attribute for the first error when c.Errors is not empty
• Multiple errors are still captured in the status description via c.Errors.String()
• Update tests to verify error.type attribute instead of span events

This provides better consistency across OpenTelemetry instrumentation packages and follows the semantic conventions for error handling.

Eshaan-byte added a commit to Eshaan-byte/opentelemetry-go-contrib that referenced this pull request

Jan 22, 2026

… errors

Fixes open-telemetry#8441

This change updates the error handling in otelgin middleware to follow the instrumentation guidelines established in open-telemetry#8386:

• Replace span.RecordError() calls with span.SetAttributes(ErrorType())
• Set error.type attribute for the first error when c.Errors is not empty
• Multiple errors are still captured in the status description via c.Errors.String()
• Update tests to verify error.type attribute instead of span events

This provides better consistency across OpenTelemetry instrumentation packages and follows the semantic conventions for error handling.

Eshaan-byte added a commit to Eshaan-byte/opentelemetry-go-contrib that referenced this pull request

Jan 28, 2026

… errors

Fixes open-telemetry#8441

This change updates the error handling in otelgin middleware to follow the instrumentation guidelines established in open-telemetry#8386:

• Replace span.RecordError() calls with span.SetAttributes(ErrorType())
• Set error.type attribute for the first error when c.Errors is not empty
• Multiple errors are still captured in the status description via c.Errors.String()
• Update tests to verify error.type attribute instead of span events

This provides better consistency across OpenTelemetry instrumentation packages and follows the semantic conventions for error handling.

This was referenced

Apr 27, 2026

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})