fix(otelhttp): make Body handling in Transport consistent with stdlib by ash2k · Pull Request #8618 · open-telemetry/opentelemetry-go-contrib (original) (raw)
ash2k mentioned this pull request
First request uses Body, following requests use Body if it can be rewound, which is only possible for well-known types that stdlib knows about. Otherwise, GetBody is used, when available.
pellared changed the title
fix(otelhttp): make fix(otelhttp): make Body handling in Transport consistent with stdlibBody and GetBody() behavior consistent with stdlib
Co-authored-by: Robert Pająk pellared@hotmail.com
ash2k deleted the fix-body-wrapping branch
pellared added a commit that referenced this pull request
Added
- Add environment variables propagation carrier in
go.opentelemetry.io/contrib/propagators/envcar. (#8442)
Changed
Upgrade
go.opentelemetry.io/otel/semconvtov1.40.0, including updates across instrumentation and detector modules. (#8631)- The semantic conventions v1.40.0 release introduces RPC breaking changes applied in this repository:
- RPC spans and metrics no longer include
network.protocol.name,network.protocol.version, ornetwork.transportattributes. rpc.client.request.size,rpc.client.response.size,rpc.server.request.size, andrpc.server.response.sizeare no longer emitted ingo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.rpc.messagespan events and their message attributes are no longer emitted ingo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc(including whenWithMessageEventsis configured).
- RPC spans and metrics no longer include
See semantic-conventions v1.40.0 release for complete details.
- The semantic conventions v1.40.0 release introduces RPC breaking changes applied in this repository:
Fixed
- Ignore informational response status codes (
100-199) except101 Switching Protocolswhen storing the HTTP status code ingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttpandgo.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux. (#6913) - Make
Bodyhandling inTransportconsistent with stdlib ingo.opentelemetry.io/contrib/instrumentation/net/http/otelhttp. (#8618) - Fix bucket boundaries for
rpc.server.call.durationandrpc.client.call.durationingo.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc. (#8642) - Host resource detector in
go.opentelemetry.io/contrib/otelconfnow includesos.attributes. (#8578)
Removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})