DOC/PERF: Decide how to handle floating point artifacts during rolling calculations (original) (raw)

Skip to content

Sign in

Appearance settings

View all features

View all solutions

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Sign in

Sign up

Appearance settings

pandas-dev / pandas Public

Additional navigation options

New issue

New issue

Closed

#40505

Closed

DOC/PERF: Decide how to handle floating point artifacts during rolling calculations

#37051

#40505

Labels

DocsNeeds DiscussionRequires discussion from core team before further actionWindowrolling, ewma, expanding

Milestone

1.3

@mroeschke

Description

@mroeschke

mroeschke

opened

on Oct 11, 2020

Currently we have a check here that artificially handles a numerical precision issue in rolling.var and rolling.std where our rolling variance calculation is carrying forward floating point artifacts. Ideally we should be using a more numerically stable algorithm (maybe Kahan summation) so this check isn't so arbitrary.

pandas/pandas/_libs/window/aggregations.pyx

Line 305 in601eff1

if result < 1e-15:

Metadata

Metadata

Assignees

No one assigned

Labels

DocsNeeds DiscussionRequires discussion from core team before further actionWindowrolling, ewma, expanding

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions