USMemorialDay defined incorrectly. · Issue #9760 · pandas-dev/pandas (original) (raw)

Skip to content

Navigation Menu

• • GitHub Copilot Write better code with AI
  • GitHub Advanced Security Find and fix vulnerabilities
  • Actions Automate any workflow
  • Codespaces Instant dev environments
  • Issues Plan and track work
  • Code Review Manage code changes
  • Discussions Collaborate outside of code
  • Code Search Find more, search less
• Explore
  • Learning Pathways
  • Events & Webinars
  • Ebooks & Whitepapers
  • Customer Stories
  • Partners
  • Executive Insights
• • GitHub Sponsors Fund open source developers
  • The ReadME Project GitHub community articles
• • Enterprise platform AI-powered developer platform
• Pricing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Description

Memorial day is incorrectly defined.

>>> from pandas.tseries.holiday import AbstractHolidayCalendar, USMemorialDay
>>> class MemorialDayCalendar(AbstractHolidayCalendar): rules=[USMemorialDay]
>>> MemorialDayCalendar().holidays('2021','2022')
<class 'pandas.tseries.index.DatetimeIndex'>
[2021-05-24]
Length: 1, Freq: None, Timezone: None

The actual date of Memorial day in 2021 is 5/31.

Memorial day should be defined as:
Holiday('Memorial Day' , month=5 , day=25, offset=DateOffset(weekday=MO(1)))