API/DEPR: Remove +/- as setops for DatetimeIndex/PeriodIndex (GH9630) by jorisvandenbossche · Pull Request #14164 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation18 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

jorisvandenbossche

@jorisvandenbossche

@jorisvandenbossche

Some todo's:

I think these should be the last remaining set ops as numeric ops that are now removed with this PR.

@jreback

we need to wait for #13077 on Period-Period (so can discuss over there). Let's limit scope to the more useful DTI-DTI

jreback

rng3 = pd.date_range('1/1/2000', freq='D', periods=5, tz=tz)
other3 = pd.DatetimeIndex([], tz=tz)
expected3 = pd.date_range('1/1/2000', freq='D', periods=5, tz=tz)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test subtracting different lengths (ValueError) IIRC; this maybe already tested in another section though

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mean this for below (dti-dti)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a test for that (and added code to give this a nicer error message)

@jorisvandenbossche

@codecov-io

Current coverage is 85.25% (diff: 96.55%)

Merging #14164 into master will increase coverage by <.01%

@@ master #14164 diff @@

Files 139 139
Lines 50496 50512 +16
Methods 0 0
Messages 0 0
Branches 0 0

Powered by Codecov. Last update 8023029...21c6cec

@jorisvandenbossche

jreback
Previous Behavior:
Previous behavior:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to standardize here, I see @jorisvandenbossche and @sinhrks changing these!

IIRC I think we do more of Previous Behavior (e.g. capitalized), and american spelling (no Behaviour). But should just pick one :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will do that in #14176

We indeed need to just make a choice between American or British :-)
(is capitalizing all words also an American habit? :-))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 2 capital words sets it off s bit more
using American spelling

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while proofreading the whatsnew, I was thinking of putting the 'New/Old Behavior' in bold, that also sets it off a bit more

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even better

@jreback

trbs added a commit to trbs/pandas that referenced this pull request

Sep 12, 2016

@trbs

…eter

trbs added a commit to trbs/pandas that referenced this pull request

Sep 12, 2016

@trbs