DOC: fix incorrect example in unstack docstring (GH14206) by sudk1896 · Pull Request #14211 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

sudk1896

@sudk1896 sudk1896 commented

Sep 13, 2016

edited by jorisvandenbossche

Loading

@jorisvandenbossche

I don't think you actually changed the output? (apart from the floating notation, which is OK). It is the output of df.unstack() that was wrong (the 2 and 3 are swapped), and which should be corrected.

@codecov-io

Current coverage is 85.24% (diff: 100%)

Merging #14211 into master will decrease coverage by <.01%

@@ master #14211 diff @@

Files 140 140
Lines 50563 50566 +3
Methods 0 0
Messages 0 0
Branches 0 0

Hits 43103 43103

Powered by Codecov. Last update 461e0e9...99c2f0b

@sudk1896

@jorisvandenbossche

@jorisvandenbossche jorisvandenbossche changed the titleDoc fix for DataFrame.unstack() DOC: fix incorrect example in unstack docstring (GH14206)

Sep 13, 2016

@jorisvandenbossche

@sudk1896 Thanks for the fix!
(small note: you had a small trailing whitespace error which was captured by our linter (I corrected it), but I would recommend setting your editor to automatically remove trailing whitespace)

@sudk1896

yarikoptic added a commit to neurodebian/pandas that referenced this pull request

Oct 13, 2016

@yarikoptic