DOC: Creating top-level user guide section, and moving pages inside by datapythonista · Pull Request #24677 · pandas-dev/pandas (original) (raw)
Agreed that smaller PRs are preferable. I worry a bit about things like this slipping through in the smaller PRs (e.g. I don't think this index page will be touched again until things are entirely done). In the meantime it'd be nice to not lose some of the few benefits of the flat structure.
On Mon, Jan 14, 2019 at 8:10 AM Marc Garcia ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/source/user_guide/index.rst <#24677 (comment)>: > @@ -0,0 +1,30 @@ +{{ header }} + +.. _user_guide: + +========== +User Guide +========== + I 100% agree, but it makes more sense to me to work on those in separate PRs after the whole restructure. There is already another PR for a top level "Getting started" section, that probably should be the linked for the "Users brand-new..." comment. I think moving all the pages and finding an agreement on all the structures will actually take quite a lot of time, and will require a decent amount of discussion. That's why I'm proposing smaller PRs, to be able to keep some progress. Also, I think that will let us see the progress at every step, and make us move in the right direction (kind of agile methodology). I mentioned it somewhere, but it was already work on trying to migrate all the documentation in a one-shot (seehttps://pandas-dev.github.io/pandas-sphinx-theme/pr-datapythonista_base/). After all the work on that, I think the approach will fail. If anyone else thinks a single PR or bigger PRs are better, I'm more than happy to leave this for someone else. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24677 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIn0J2-L3O3X5rs7nmREiQFEueUQkks5vDI_FgaJpZM4Z2lfX> . On Mon, Jan 14, 2019 at 8:10 AM Marc Garcia ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/source/user_guide/index.rst <#24677 (comment)>: > @@ -0,0 +1,30 @@ +{{ header }} + +.. _user_guide: + +========== +User Guide +========== + I 100% agree, but it makes more sense to me to work on those in separate PRs after the whole restructure. There is already another PR for a top level "Getting started" section, that probably should be the linked for the "Users brand-new..." comment. I think moving all the pages and finding an agreement on all the structures will actually take quite a lot of time, and will require a decent amount of discussion. That's why I'm proposing smaller PRs, to be able to keep some progress. Also, I think that will let us see the progress at every step, and make us move in the right direction (kind of agile methodology). I mentioned it somewhere, but it was already work on trying to migrate all the documentation in a one-shot (seehttps://pandas-dev.github.io/pandas-sphinx-theme/pr-datapythonista_base/). After all the work on that, I think the approach will fail. If anyone else thinks a single PR or bigger PRs are better, I'm more than happy to leave this for someone else. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24677 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIn0J2-L3O3X5rs7nmREiQFEueUQkks5vDI_FgaJpZM4Z2lfX> .