Fix concat not respecting order of OrderedDict by alexander-ponomaroff · Pull Request #25224 · pandas-dev/pandas (original) (raw)

Sounds good.

…

On Tue, Mar 12, 2019 at 12:46 PM William Ayd ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pandas/tests/groupby/test_groupby.py <#25224 (comment)>: > @@ -1690,14 +1690,11 @@ def test_groupby_agg_ohlc_non_first(): [1, 1, 1, 1, 1], [1, 1, 1, 1, 1] ], columns=pd.MultiIndex.from_tuples(( - ('foo', 'ohlc', 'open'), ('foo', 'ohlc', 'high'), - ('foo', 'ohlc', 'low'), ('foo', 'ohlc', 'close'), - ('foo', 'sum', 'foo'))), index=pd.date_range( + ('foo', 'sum', 'foo'), ('foo', 'ohlc', 'open'), The latter. So this has implications to ordering which previously would have been non-deterministic in Py35. So I think it might make sense as a follow up to use a OrderedDict and make better guarantees about the returned column order, but don't think that should hold this one up — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#25224 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIg6jzfNZb8_yQW9MXzmjZPYWaO0Cks5vV-gIgaJpZM4attTh> .