Fixturize tests/frame/test_operators.py by h-vetinari · Pull Request #25641 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation11 Commits5 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
One more steps towards #22471.
Codecov Report
Merging #25641 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #25641 +/- ##
Coverage 91.26% 91.26%
Files 173 173
Lines 52968 52968
Hits 48339 48339
Misses 4629 4629
| Flag | Coverage Δ | |
|---|---|---|
| #multiple | 89.83% <ø> (ø) | ⬆️ |
| #single | 41.71% <ø> (ø) | ⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 26cfa28...09bfaa1. Read the comment docs.
Codecov Report
Merging #25641 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #25641 +/- ##
Coverage 91.29% 91.29%
Files 173 173
Lines 52961 52961
Hits 48349 48349
Misses 4612 4612
| Flag | Coverage Δ | |
|---|---|---|
| #multiple | 89.86% <ø> (ø) | ⬆️ |
| #single | 41.73% <ø> (ø) | ⬆️ |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 21769e9...32b18d2. Read the comment docs.
| @@ -94,6 +94,9 @@ def mixed_float_frame(): |
|---|
| return df |
| mixed_float_frame2 = mixed_float_frame |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you see this being used elsewhere than the one test? If not probably better just to create a copy directly within the test
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed don't want this here
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think you missed removal of this in last commit
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change the way empty is written as per comment
| @@ -94,6 +94,9 @@ def mixed_float_frame(): |
|---|
| return df |
| mixed_float_frame2 = mixed_float_frame |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed don't want this here
| @@ -94,6 +94,9 @@ def mixed_float_frame(): |
|---|
| return df |
| mixed_float_frame2 = mixed_float_frame |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think you missed removal of this in last commit
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sighingnow added a commit to sighingnow/pandas that referenced this pull request
sighingnow added a commit to sighingnow/pandas that referenced this pull request
- master: Fixturize tests/frame/test_operators.py (pandas-dev#25641) Update ValueError message in corr (pandas-dev#25729)
Conflicts:
doc/source/whatsnew/v0.25.0.rst
Labels
pandas testing functions or related to the test suite