CI: Fix npdev build post Cython annotation change by mroeschke · Pull Request #47670 · pandas-dev/pandas (original) (raw)

mroeschke pushed a commit that referenced this pull request

Sep 8, 2022

…specific directive is used (#46405)

• Added test representative of #46319. Should fail on CI

• Added a gha worker with non utf 8 zh_CN encoding

• Attempt to fix the encoding so that locale works

• Added the fix, but not using it for now, until CI is able to reproduce the issue.

• Crazy idea: maybe simply removing the .utf8 modifier will use the right encoding !

• Hopefully fixing the locale not available error

• Now simply generating the locale, not updating the ubuntu one

• Trying to install the locale without enabling it

• Stupid mistake

• Testing the optional locale generator condition

• Put back all runners

• Added whatsnew

• Now using the fix

• As per code review: moved locale-switching fixture overridden_locale to conftest

• Flake8

• Added comments on the runner

• Added a non-utf8 locale in the it_IT runner. Added the zh_CN.utf8 locale in the tests

• Improved readability of fixture overridden_locale as per code review

• Added two comments on default encoding

• Fixed #46319 by adding a new char_to_string_locale function in the tslibs.util module, able to decode char* using the current locale.

• As per code review: modified the test to contain non-utf8 chars. Fixed the resulting issue.

• Split the test in two for clarity

• Fixed test and flake8 error.

• Updated whatsnew to ref #46468 . Updated test name

• Removing wrong whatsnew bullet

• Nitpick on whatsnew as per code review

• Fixed build error rst directive

• Names incorrectly reverted in last merge commit

• Fixed test_localization so that #46595 can be demonstrated on windows targets (even if today these do not run on windows targets, see #46597)

• Fixed tm.set_locale context manager, it could error and leak when category LC_ALL was used. Fixed #46595

• Removed the fixture as per code review, and added corresponding parametrization in tests.

• Dummy mod to trigger CI again

• reverted dummy mod

• Attempt to fix the remaining error on the numpy worker

• Fixed issue in _from_ordinal

• Added asserts to try to understand

• Reverted debugging asserts and applied fix for numpy repeat from #47670.

• Fixed the last issue on numpy dev: a TypeError message had changed

• Code review: Removed EXTRA_LOC

• Code review: removed commented line

• Code review: reverted out of scope change

• Code review: reverted out of scope change

• Fixed unused import

• Fixed revert mistake

• Moved whatsnew to 1.6.0

• Update pandas/tests/io/parser/test_quoting.py

Co-authored-by: Sylvain MARIE sylvain.marie@se.com