WEB: Update versions json to fix version switcher in the docs by datapythonista · Pull Request #48655 · pandas-dev/pandas (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

datapythonista

@datapythonista

phofl

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't need the full path?

@datapythonista

So we don't need the full path?

The url is only used in the new version of the theme, and for what I saw the value is used directly in the href, so probably better without then I think.

@phofl

I am asking because initially we had the full path:

    "switcher": {
         "json_url": "https://pandas.pydata.org/versions.json",
         "url_template": "https://pandas.pydata.org/{version}/",
         "json_url": "/versions.json",
         "version_match": switcher_version,
     },

but this is part of the conf.py, so the old versions of the docs can still access this, correct?

https://github.com/pandas-dev/pandas/pull/48285/files

@datapythonista

Yes, everything in conf.py stays in the already rendered version of the docs, so it's not affecting the released versions, and we can't update it for them either.

Both will work, with and without the domain. But without will allow for example to test it in the new server without unintentionally going to the old one.

phofl

@phofl phofl added this to the 1.6 milestone

Sep 20, 2022

@phofl

phofl pushed a commit to phofl/pandas that referenced this pull request

Sep 22, 2022

@datapythonista @phofl

mroeschke added a commit that referenced this pull request

Sep 26, 2022

…8662)

Co-authored-by: Matthew Roeschke 10647082+mroeschke@users.noreply.github.com

scorecard-action does not have a major version tag.

Temporarily disabling github.repository check to ensure action now works.

https://pandas.pydata.org/docs/reference/api/pandas.merge.html It should be "str | bool" instead of just string

fixed type hint in merge.py

Update indicator type hint in _MergeOperation

Added type hint _MergeOperation init

DOC: Document default value for options.display.max_cols

display.max_cols has a default value of 20 when not running in a terminal such as Jupyter Notebook

Co-Authored-By: Matthew Roeschke 10647082+mroeschke@users.noreply.github.com

Co-authored-by: Matthew Roeschke 10647082+mroeschke@users.noreply.github.com

Co-authored-by: Matthew Roeschke 10647082+mroeschke@users.noreply.github.com Co-authored-by: Ralf Gommers ralf.gommers@gmail.com Co-authored-by: Marc Garcia garcia.marc@gmail.com Co-authored-by: Luke Manley lukemanley@gmail.com Co-authored-by: Siddhartha Gandhi siddhartha.a.gandhi@gmail.com Co-authored-by: Torsten Wörtwein twoertwein@users.noreply.github.com Co-authored-by: Xiao Yuan yuanx749@gmail.com Co-authored-by: paradox-lab 57354735+paradox-lab@users.noreply.github.com Co-authored-by: Pedro Nacht 15221358+pnacht@users.noreply.github.com Co-authored-by: dataxerik dsshar@gmail.com Co-authored-by: jbrockmendel jbrockmendel@gmail.com Co-authored-by: Pablo 48098178+PabloRuizCuevas@users.noreply.github.com Co-authored-by: tmoschou 5567550+tmoschou@users.noreply.github.com Co-authored-by: Thomas Li 47963215+lithomas1@users.noreply.github.com Co-authored-by: Richard Shadrach 45562402+rhshadrach@users.noreply.github.com

noatamir pushed a commit to noatamir/pandas that referenced this pull request

Nov 9, 2022

@datapythonista @noatamir

noatamir pushed a commit to noatamir/pandas that referenced this pull request

Nov 9, 2022

…ndas-dev#48662)

Co-authored-by: Matthew Roeschke 10647082+mroeschke@users.noreply.github.com

scorecard-action does not have a major version tag.

Temporarily disabling github.repository check to ensure action now works.

https://pandas.pydata.org/docs/reference/api/pandas.merge.html It should be "str | bool" instead of just string

fixed type hint in merge.py

Update indicator type hint in _MergeOperation

Added type hint _MergeOperation init

DOC: Document default value for options.display.max_cols

display.max_cols has a default value of 20 when not running in a terminal such as Jupyter Notebook

Co-Authored-By: Matthew Roeschke 10647082+mroeschke@users.noreply.github.com

Co-authored-by: Matthew Roeschke 10647082+mroeschke@users.noreply.github.com

Co-authored-by: Matthew Roeschke 10647082+mroeschke@users.noreply.github.com Co-authored-by: Ralf Gommers ralf.gommers@gmail.com Co-authored-by: Marc Garcia garcia.marc@gmail.com Co-authored-by: Luke Manley lukemanley@gmail.com Co-authored-by: Siddhartha Gandhi siddhartha.a.gandhi@gmail.com Co-authored-by: Torsten Wörtwein twoertwein@users.noreply.github.com Co-authored-by: Xiao Yuan yuanx749@gmail.com Co-authored-by: paradox-lab 57354735+paradox-lab@users.noreply.github.com Co-authored-by: Pedro Nacht 15221358+pnacht@users.noreply.github.com Co-authored-by: dataxerik dsshar@gmail.com Co-authored-by: jbrockmendel jbrockmendel@gmail.com Co-authored-by: Pablo 48098178+PabloRuizCuevas@users.noreply.github.com Co-authored-by: tmoschou 5567550+tmoschou@users.noreply.github.com Co-authored-by: Thomas Li 47963215+lithomas1@users.noreply.github.com Co-authored-by: Richard Shadrach 45562402+rhshadrach@users.noreply.github.com