CLN: enforce the deprecation of exposing blocks in core.internals by natmokval · Pull Request #58467 · pandas-dev/pandas (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation12 Commits15 Checks36 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
xref #55355,
enforced the deprecation of create_block_manager_from_blocks
xref #55139
enforced the deprecation of exposing blocks in core.internals
Comment on lines 658 to 659
| if Version(pyarrow.__version__) == "10.0.1": |
|---|
| pytest.skip("skip the pyarrow version '10.0.1'") |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if Version(pyarrow.__version__) == "10.0.1": |
|---|
| pytest.skip("skip the pyarrow version '10.0.1'") |
| pytest.importorskip("pyarrow", "10.0.1") |
And similar below
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your help. It seems that it doesn't work when using pytest.importorskip("pyarrow", "10.0.1"), but it works properly with pytest.importorskip("pyarrow", "11.0.0")
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request
CLN: enforce the deprecation of exposing blocks in core.internals
remove the function getattr, and entries from all
fix mypy error
add a note to v3.0.0
skip parquet tests for minimum Pyarrow version
fixup test_basic
fix pre-commit error
skip pyarrow=10.0.1 in test_parquet.py
fix mypy error
fix pre-commit error
fixup test_parquet.py
fix pre-commit error
fixup test_parquet.py
replacee pytest.skip with pytest.importorskip
skip pyarrow '10.0.1'
I think we need to revert this, and first bump the DeprecationWarning to a FutureWarning. I actually don't care that much about the exact warning class, though, but I think that this is generally the correct way to deal with something we started deprecating with a DeprecationWarning. But I think we should care about keeping this around a bit longer (even though it is with a warning), because this simply means that you cannot use pandas 3.0 with pyarrow < 15, while we actually have a minimum version requirement of pyarrow 10
I think that this is generally the correct way to deal with something we started deprecating with a DeprecationWarning
Which is similarly as Richard said in #50578 (comment)
I think we need to revert this, and first bump the DeprecationWarning to a FutureWarning. I actually don't care that much about the exact warning class, though, but I think that this is generally the correct way to deal with something we started deprecating with a DeprecationWarning. But I think we should care about keeping this around a bit longer (even though it is with a warning), because this simply means that you cannot use pandas 3.0 with pyarrow < 15, while we actually have a minimum version requirement of pyarrow 10
thanks @jorisvandenbossche, I opened PR to revert this
WillAyd added a commit to WillAyd/pandas that referenced this pull request
lithomas1 pushed a commit to lithomas1/pandas that referenced this pull request
WillAyd added a commit to WillAyd/pandas that referenced this pull request