Rollup merge of #129963 - rjooske:fix/inaccurate_to_string_lossy_doc,… · patricklam/verify-rust-std@2699de6 (original) (raw)
Navigation Menu
- GitHub Copilot Write better code with AI
- GitHub Models New Manage and compare prompts
- GitHub Advanced Security Find and fix vulnerabilities
- Actions Automate any workflow
- Codespaces Instant dev environments
- Issues Plan and track work
- Code Review Manage code changes
- Discussions Collaborate outside of code
- Code Search Find more, search less
- Explore
- Pricing
Provide feedback
Saved searches
Use saved searches to filter your results more quickly
Appearance settings
Commit 2699de6
Rollup merge of rust-lang#129963 - rjooske:fix/inaccurate_to_string_lossy_doc, r=workingjubilee
Inaccurate `{Path,OsStr}::to_string_lossy()` documentation The documentation of `Path::to_string_lossy()` and `OsStr::to_string_lossy()` says the following: > Any non-Unicode sequences are replaced with `U+FFFD REPLACEMENT CHARACTER` which didn't immediately make sense to me. ("non-Unicode sequences"?) Since both `to_string_lossy` functions eventually become just a call to `String::from_utf8_lossy`, I believe the documentation meant to say: > Any *non-UTF-8* sequences are replaced with `U+FFFD REPLACEMENT CHARACTER` This PR corrects this mistake in the documentation. For the record, a similar quote can be found in the documentation of `String::from_utf8_lossy`: > ... During this conversion, `from_utf8_lossy()` will replace any invalid UTF-8 sequences with `U+FFFD REPLACEMENT CHARACTER`, ...
File tree
2 files changed
lines changed
2 files changed
lines changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -852,7 +852,7 @@ impl OsStr { | ||
| 852 | 852 | |
| 853 | 853 | /// Converts an `OsStr` to a [Cow]<[str]>. |
| 854 | 854 | /// |
| 855 | - /// Any non-Unicode sequences are replaced with | |
| 855 | + /// Any non-UTF-8 sequences are replaced with | |
| 856 | 856 | /// [`U+FFFD REPLACEMENT CHARACTER`][U+FFFD]. |
| 857 | 857 | /// |
| 858 | 858 | /// [U+FFFD]: crate::char::REPLACEMENT_CHARACTER |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -2200,7 +2200,7 @@ impl Path { | ||
| 2200 | 2200 | |
| 2201 | 2201 | /// Converts a `Path` to a [`Cow`]. |
| 2202 | 2202 | /// |
| 2203 | - /// Any non-Unicode sequences are replaced with | |
| 2203 | + /// Any non-UTF-8 sequences are replaced with | |
| 2204 | 2204 | /// [`U+FFFD REPLACEMENT CHARACTER`][U+FFFD]. |
| 2205 | 2205 | /// |
| 2206 | 2206 | /// [U+FFFD]: super::char::REPLACEMENT_CHARACTER |