Simplify match patterns by blakeembrey · Pull Request #426 · pillarjs/path-to-regexp (original) (raw)

Conversation

Opening for posterity/interest, but unlikely to land due to the breaking change from the first parameter to the last being greedy. It is a much simpler solution to handle backtracking protection though, as you just always restrict forward until you hit a wildcard, then restrict backward.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.75%. Comparing base (34cb451) to head (51b1abd).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@ ## master #426 +/- ##

• Coverage 99.75% 99.75% -0.01%

  Files 1 1
  Lines 415 410 -5
  Branches 156 149 -7

• Hits 414 409 -5
  Misses 1 1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

1 participant