Implement respond_to? in RubyMessage by JasonLunn · Pull Request #9677 · protocolbuffers/protobuf (original) (raw)

@JasonLunn

…implemented by method_missing return true. Add regression tests.

Fix null pointer exceptions exposed by new unit tests.

Code cleanup: remove test code that was skipping several unit tests only on JRuby.

Fixes issue protocolbuffers#9202.

@JasonLunn

@JasonLunn

…t respond_to? does not depend on whether the oneof is currently cleared.

@JasonLunn

…t respond_to? does not depend on whether the oneof is currently cleared.

Code cleanup: reenable more tests on JRuby.

@JasonLunn

…pting to assign to a oneof.

@JasonLunn

@JasonLunn

@JasonLunn

Code cleanup: Eliminate noisy warnings when running tests by

  1. removing or using unused variables
  2. wrapping ambiguous parameters in parentheses

@JasonLunn

JasonLunn added a commit to JasonLunn/protobuf that referenced this pull request

Mar 31, 2022

@JasonLunn

All synthetic methods implemented by method_missing are now supported by respond_to?.

Fixes issue protocolbuffers#9202.

(cherry picked from commit 8e7f936)

mkruskal-google added a commit that referenced this pull request

Apr 7, 2022

(cherry picked from commit 58e320a)

All synthetic methods implemented by method_missing are now supported by respond_to?.

Fixes issue #9202.

(cherry picked from commit 8e7f936)

Fix building packaged PHP extension

(cherry picked from commit 7f9901c)

Co-authored-by: Jason Lunn jason.lunn@gmail.com Co-authored-by: Jorg Brown jorg.brown@gmail.com

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})