remove X509StoreFlags.NOTIFY_POLICY by reaperhulk · Pull Request #1213 · pyca/pyopenssl (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation0 Commits3 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

reaperhulk

alex

alex approved these changes Apr 21, 2023

alex added a commit to pyca/cryptography that referenced this pull request

Jul 1, 2023

@alex

@alex alex mentioned this pull request

Jul 1, 2023

reaperhulk pushed a commit to pyca/cryptography that referenced this pull request

Jul 3, 2023

@alex

EchterAgo added a commit to EchterAgo/Electron-Cash that referenced this pull request

Mar 20, 2024

@EchterAgo

cryptography removed X509_V_FLAG_NOTIFY_POLICY which is still imported when using the pysatochip package but unused.

To fix this we update pyOpenSSL to version 24.1.0

pyca/cryptography#9163 pyca/pyopenssl#1213

  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/pysatochip/certificate_validator.py", line 6, in <module>
    import OpenSSL
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import crypto, SSL
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/crypto.py", line 1556, in <module>
    class X509StoreFlags(object):
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/crypto.py", line 1575, in X509StoreFlags
    NOTIFY_POLICY = _lib.X509_V_FLAG_NOTIFY_POLICY

EchterAgo added a commit to EchterAgo/Electron-Cash that referenced this pull request

Mar 20, 2024

@EchterAgo

cryptography removed X509_V_FLAG_NOTIFY_POLICY which is still imported when using the pysatochip package but unused.

To fix this we update pyOpenSSL to version 24.1.0

pyca/cryptography#9163 pyca/pyopenssl#1213

  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/pysatochip/certificate_validator.py", line 6, in <module>
    import OpenSSL
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import crypto, SSL
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/crypto.py", line 1556, in <module>
    class X509StoreFlags(object):
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/crypto.py", line 1575, in X509StoreFlags
    NOTIFY_POLICY = _lib.X509_V_FLAG_NOTIFY_POLICY

Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request

Apr 3, 2024

@EchterAgo @PiRK

Summary:

Clean up the pip-audit result by bumping some deps. Ignore some that aren't applicable to the run-time> .

build: Update PyOpenSSL to version 24.1.0

cryptography removed X509_V_FLAG_NOTIFY_POLICY which is still imported when using the pysatochip package but unused.

To fix this we update pyOpenSSL to version 24.1.0

pyca/cryptography#9163 pyca/pyopenssl#1213

  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/pysatochip/certificate_validator.py", line 6, in <module>
    import OpenSSL
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import crypto, SSL
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/crypto.py", line 1556, in <module>
    class X509StoreFlags(object):
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/crypto.py", line 1575, in X509StoreFlags
    NOTIFY_POLICY = _lib.X509_V_FLAG_NOTIFY_POLICY

This is a backport of [[Electron-Cash/Electron-Cash#2796 | electroncash#2796]] and [[Electron-Cash/Electron-Cash#2815 | electroncash#2815]]

Also deduplicate some determinstic requirements in requirements-hw.txt

Depends on D15868

Test Plan: Build all release binaries, check that the executables work

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D15870

Fabcien pushed a commit to Bitcoin-ABC/ElectrumABC that referenced this pull request

Apr 4, 2024

@EchterAgo

Summary:

Clean up the pip-audit result by bumping some deps. Ignore some that aren't applicable to the run-time> .

build: Update PyOpenSSL to version 24.1.0

cryptography removed X509_V_FLAG_NOTIFY_POLICY which is still imported when using the pysatochip package but unused.

To fix this we update pyOpenSSL to version 24.1.0

pyca/cryptography#9163 pyca/pyopenssl#1213

  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/pysatochip/certificate_validator.py", line 6, in <module>
    import OpenSSL
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/__init__.py", line 8, in <module>
    from OpenSSL import crypto, SSL
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/crypto.py", line 1556, in <module>
    class X509StoreFlags(object):
  File "/tmp/.mount_Electrig7PIy/usr/lib/python3.11/site-packages/OpenSSL/crypto.py", line 1575, in X509StoreFlags
    NOTIFY_POLICY = _lib.X509_V_FLAG_NOTIFY_POLICY

This is a backport of [[Electron-Cash#2796 | electroncash#2796]] and [[Electron-Cash#2815 | electroncash#2815]]

Also deduplicate some determinstic requirements in requirements-hw.txt

Depends on D15868

Test Plan: Build all release binaries, check that the executables work

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D15870

2 participants

@reaperhulk @alex