bpo-30830: logging.config.listen() calls server_close() (#3524) · python/cpython@97d7e65 (original) (raw)

Skip to content

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Commit 97d7e65

bpo-30830: logging.config.listen() calls server_close() (#3524)

The ConfigSocketReceiver.serve_until_stopped() method from logging.config.listen() now calls server_close() (of socketserver.ThreadingTCPServer) rather than closing manually the socket. While this change has no effect yet, it will help to prevent dangling threads once ThreadingTCPServer.server_close() will join spawned threads (bpo-31233).

File tree

1 file changed

lines changed

1 file changed

lines changed

Original file line number Diff line number Diff line change
@@ -887,7 +887,7 @@ def serve_until_stopped(self):
887 887 logging._acquireLock()
888 888 abort = self.abort
889 889 logging._releaseLock()
890 -self.socket.close()
890 +self.server_close()
891 891
892 892 class Server(threading.Thread):
893 893