gh-99108: Refactor _sha256 & _sha512 into _sha2. by gpshead · Pull Request #101924 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits13 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This merges their code. They're backed by the same single HACL* static library, having them be a single module simplifies maintenance.
This should unbreak the wasm enscripten builds that currently fail due to linking in --whole-archive mode and the HACL* library appearing twice.
Long unnoticed error fixed: _sha512.SHA384Type was doubly assigned and was actually SHA512Type. Nobody depends on those internal names.
This is a followup to PRs #101707 and #101917.
This merges their code. They're backed by the same single HACL* star static library, having them be a single module simplifies maintenance.
This should unbreak the wasm enscripten builds that currently fail due to linking in --whole-archive mode and the HACL* library appearing twice.
Long unnoticed error fixed: _sha512.SHA384Type was doubly assigned and was
actually SHA512Type. Nobody depends on those internal names.
🤖 New build scheduled with the buildbot fleet by @gpshead for commit 4c6a4fb 🤖
If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
BTW, I'm pretty sure the refleaks are related to #101908.
(this is how useful github vscode editor w/o ability to build and test before commit is...)
🤖 New build scheduled with the buildbot fleet by @gpshead for commit fb6454d 🤖
If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
🤖 New build scheduled with the buildbot fleet by @gpshead for commit 32b8f91 🤖
If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
🤖 New build scheduled with the buildbot fleet by @gpshead for commit b67918d 🤖
If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
picnixz added a commit that referenced this pull request
Since we plan to introduce a built-in implementation for HMAC based on HACL*, it becomes important for the HMAC tests to be flexible enough to avoid code duplication.
In addition to the new layout based on mixin classes, we extend test coverage by
also testing the __repr__ of HMAC objects and the HMAC one-shot functions.
We also fix the import to _sha256 which, since gh-101924, resulted in some tests being
skipped as the module is no more available (its content was moved to the _sha2 module).
seehwan pushed a commit to seehwan/cpython that referenced this pull request
Since we plan to introduce a built-in implementation for HMAC based on HACL*, it becomes important for the HMAC tests to be flexible enough to avoid code duplication.
In addition to the new layout based on mixin classes, we extend test coverage by
also testing the __repr__ of HMAC objects and the HMAC one-shot functions.
We also fix the import to _sha256 which, since pythongh-101924, resulted in some tests being
skipped as the module is no more available (its content was moved to the _sha2 module).