GH-89812: Simplify creation of symlinks in pathlib tests. by barneygale · Pull Request #106061 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

barneygale

Remove PathTest.dirlink() function. Symlinks in PathTest.setUp() are created using os.symlink() directly; symlinks in test functions use Path.symlink_to() in order to make the tests applicable to a (near-)future AbstractPath class.

@barneygale

Remove PathTest.dirlink() function. Symlinks in PathTest.setUp() are created using os.symlink() directly; symlinks in test functions use Path.symlink_to() in order to make the tests applicable to a (near-)future AbstractPath class.

CAM-Gerlach

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert on symlink handling, but while it does make the test code slightly less concise, there appears to be a motivated reason to do so, it eliminates a workaround, and is needed for future improvements. I also couldn't spot any obvious issues in the implementation, though again, I defer to Barney and others regarding SME issues.

@barneygale

Thank you for the review CAM!

manosriram pushed a commit to manosriram/cpython that referenced this pull request

Jul 1, 2023

@barneygale @manosriram

…onGH-106061)

Remove PathTest.dirlink() function. Symlinks in PathTest.setUp() are created using os.symlink() directly; symlinks in test functions use Path.symlink_to() in order to make the tests applicable to a (near-)future AbstractPath class.