gh-106316: Remove pytime.h header file by vstinner · Pull Request #106317 · python/cpython (original) (raw)

Remove the "cpython/pytime.h" header file: it only contained private functions. Move functions to the internal pycore_time.h header file.

Move tests from _testcapi to _testinternalcapi. Rename also test methods to have the same name than tested C functions.

No longer export these functions:

• _PyTime_Add()
• _PyTime_As100Nanoseconds()
• _PyTime_FromMicrosecondsClamp()
• _PyTime_FromTimespec()
• _PyTime_FromTimeval()
• _PyTime_GetPerfCounterWithInfo()
• _PyTime_MulDiv()

requested review froma team, abalkin, brettcannon, encukou, ericsnowcurrently, ezio-melotti, hugovk, ncoghlan, pganssle, rhettinger and warsaw as code owners

July 1, 2023 19:43

encukou added a commit to encukou/cpython that referenced this pull request

Feb 12, 2024

…ader file (python#106317)"

This reverts commit 46d7761, and returns to the status quo (3.12).

Tests are left in _testinternalcapi; this sounds appropriate for underscored functions.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})