gh-109045: Remove remaining LIMITED_API_AVAILABLE checks in tests by andersk · Pull Request #109046 · python/cpython (original) (raw)

andersk

Copy link

Contributor

@andersk andersk commented

Sep 7, 2023

edited

Loading

Commit 13a0007 (#108663) made all Python builds compatible with the Limited API, and removed the LIMITED_API_AVAILABLE flag. However, some tests were still checking for that flag, so they were now being incorrectly skipped. Remove these checks to let these tests run again.

Fixes #109045.

@andersk

`pythongh-109045[: Remove remaining LIMITED_API_AVAILABLE checks in tests](/python/cpython/pull/109046/commits/5c0de5e8189399fa70f082101e9492baa555b4a0 "gh-109045: Remove remaining LIMITED_API_AVAILABLE checks in tests

Commit 13a00078b81776b23b0b6add69b848382240d1f2 (#108663) made all Python builds compatible with the Limited API, and removed the LIMITED_API_AVAILABLE flag. However, some tests were still checking for that flag, so they were now being incorrectly skipped. Remove these checks to let these tests run again.

Signed-off-by: Anders Kaseorg andersk@mit.edu") `

[5c0de5e](/python/cpython/pull/109046/commits/5c0de5e8189399fa70f082101e9492baa555b4a0)

Commit 13a0007 (python#108663) made all Python builds compatible with the Limited API, and removed the LIMITED_API_AVAILABLE flag. However, some tests were still checking for that flag, so they were now being incorrectly skipped. Remove these checks to let these tests run again.

Signed-off-by: Anders Kaseorg andersk@mit.edu

@bedevere-bot bedevere-bot added the awaiting review label

Sep 7, 2023

@bedevere-bot bedevere-bot mentioned this pull request

Sep 7, 2023

Limited API tests are now incorrectly skipped unconditionally#109045

Closed

@vstinner vstinner added the skip news label

Sep 7, 2023

@vstinner vstinner merged commit f42edf1 into python:main

Sep 7, 2023

@bedevere-bot bedevere-bot removed the awaiting review label

Sep 7, 2023

@vstinner

Copy link

Member

vstinner commented

Sep 7, 2023

Oops! I didn't know that the macro was used outside parts.h! Thanks for the fix.

@andersk andersk deleted the limited-api-available branch

September 7, 2023 02:44