bpo-35704: Prevent test_shutil fail result when AIX is 32-bit and MAXDATA < 0x20000000 by aixtools · Pull Request #11500 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits4 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

aixtools

@aixtools

@aixtools

@aixtools

… 32-bit AIX

when MAXDATA setting is less than 0x20000000.

ncoghlan

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original version of the patch for bpo-35633 has snuck into this PR, so that needs to be reverted. The bpo-35704 itself looks fine to me, though - I just have one question regarding the availability of /usr/bin/dump on AIX systems.

@bedevere-bot

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@aixtools

@aixtools

I have made the requested changes; please review again.

@bedevere-bot

Thanks for making the requested changes!

@ncoghlan: please review the changes made to this pull request.

ncoghlan

@ncoghlan

Ah, d'oh, I was too hasty with the updated review, as the wrong NEWS entry got merged - the one for bpo-35704 got deleted, and the one for bpo-35633 was merged.