GH-105879: Note exec/eval keyword change in What's New by ncoghlan · Pull Request #121831 · python/cpython (original) (raw)

webknjaz added a commit to webknjaz/cpython that referenced this pull request

Previously, those flags would sometimes end up having empty string values which tends to break evaluating them as JSON. This patch adds false fallbacks to all such outputs.

This allows feeding them to fromJSON() without a fear of them causing surprising internal behaviors in the GitHub Actions CI/CD workflows platform itself [[1]]. The behavior observed was that some skipped jobs wouldn't show up in the workflow sidebar view at all, would display in the graph view as Waiting for pending jobs and in the ${{ needs }} context, they would have a result: failure entry.

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment)

webknjaz added a commit to webknjaz/cpython that referenced this pull request

Previously, those flags would sometimes end up having empty string values which tends to break evaluating them as JSON. This patch adds false fallbacks to all such outputs.

This allows feeding them to fromJSON() without a fear of them causing surprising internal behaviors in the GitHub Actions CI/CD workflows platform itself [[1]]. The behavior observed was that some skipped jobs wouldn't show up in the workflow sidebar view at all, would display in the graph view as Waiting for pending jobs and in the ${{ needs }} context, they would have a result: failure entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment) [2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244

webknjaz added a commit to webknjaz/cpython that referenced this pull request

Previously, those flags would sometimes end up having empty string values, which tends to break evaluating them as JSON. This patch adds false fallbacks to all such outputs.

This allows feeding them to fromJSON() without a fear of them causing surprising internal behaviors in the GitHub Actions CI/CD workflows platform itself [[1]]. The behavior observed was that some skipped jobs wouldn't show up in the workflow sidebar view at all, would display in the graph view as Waiting for pending jobs and in the ${{ needs }} context, they would have a result: failure entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment) [2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244

webknjaz added a commit to webknjaz/cpython that referenced this pull request

Previously, those flags would sometimes end up having empty string values, which tends to break evaluating them as JSON. This patch adds false fallbacks to all such outputs.

This allows feeding them to fromJSON() without a fear of them causing surprising internal behaviors in the GitHub Actions CI/CD workflows platform itself [[1]]. The behavior observed was that some skipped jobs wouldn't show up in the workflow sidebar view at all, would display in the graph view as Waiting for pending jobs and in the ${{ needs }} context, they would have a result: failure entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment) [2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244

webknjaz added a commit to webknjaz/cpython that referenced this pull request

Previously, those flags would sometimes end up having empty string values, which tends to break evaluating them as JSON. This patch adds false fallbacks to all such outputs.

This allows feeding them to fromJSON() without a fear of them causing surprising internal behaviors in the GitHub Actions CI/CD workflows platform itself [[1]]. The behavior observed was that some skipped jobs wouldn't show up in the workflow sidebar view at all, would display in the graph view as Waiting for pending jobs and in the ${{ needs }} context, they would have a result: failure entry [[2]].

This should help make PRs like python#121831 mergeable again.

[1]: python#121766 (comment) [2]: https://github.com/python/cpython/actions/runs/9950331379/job/27501637459?pr=121831#step:2:244

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

(cherry picked from commit d7a099d)

Co-authored-by: Alyssa Coghlan ncoghlan@gmail.com

ncoghlan added a commit that referenced this pull request

GH-105879: Note exec/eval keyword change in What's New (GH-121831) (cherry picked from commit d7a099d)

Co-authored-by: Alyssa Coghlan ncoghlan@gmail.com Co-authored-by: Łukasz Langa lukasz@langa.pl

estyxx pushed a commit to estyxx/cpython that referenced this pull request

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})