gh-122905: Sanitize names in zipfile.Path. by jaraco · Pull Request #122906 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation15 Commits2 Checks44 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Member
•
edited by bedevere-appbot
Loading
This behavior has been published in jaraco/zipp since 2024-05-31, so I'm confident it's stable.
Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326)
Co-authored-by: Jason R. Coombs jaraco@jaraco.com
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326)
Co-authored-by: Jason R. Coombs jaraco@jaraco.com
Sorry, @jaraco, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.11
Sorry, @jaraco, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.10
Sorry, @jaraco, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.9
Sorry, @jaraco, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9cd03263100ddb1657826cc4a71470786cab3932 3.8
jaraco added a commit to jaraco/cpython that referenced this pull request
jaraco added a commit to jaraco/cpython that referenced this pull request
Ported from zipp 3.19.1; ref jaraco/zippGH-119. (cherry picked from commit 9cd0326)
Co-authored-by: Jason R. Coombs jaraco@jaraco.com
I've proposed the backport to 3.11. I'm hoping to cherrypick that to 3.10 and earlier, assuming it's accepted, rather that cherry-picking the change in main and re-reconciling the conflicts.
jaraco pushed a commit that referenced this pull request
jaraco pushed a commit that referenced this pull request
pablogsal pushed a commit that referenced this pull request
jaraco added a commit to jaraco/cpython that referenced this pull request
jaraco added a commit to jaraco/cpython that referenced this pull request
blhsing pushed a commit to blhsing/cpython that referenced this pull request
That's weird - all three backports (3.8, 3.9, 3.10) are failing on the macos runners, two of them with segmentation faults. I'm 99.9% certain these changes aren't directly implicated. I've restarted the runners to see if maybe that clears things up, but there seems to be some stability issues on those branches.
pablogsal pushed a commit that referenced this pull request
This introduced a regression: #123270.
