gh-91126: Docs and tests for slotted dataclasses with __init_subclass__ by sobolevn · Pull Request #123342 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits2 Checks35 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

sobolevn

Member

@sobolevn sobolevn commented

Aug 26, 2024

•

edited by github-actionsbot

Loading

@sobolevn

@sobolevn

carljm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sobolevn

carljm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sobolevn

I will wait a bit for @ericvsmith's review and merge it in a couple of days. Thanks!

@miss-islington-app

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 1, 2024

@sobolevn @miss-islington

@bedevere-app

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 1, 2024

@sobolevn @miss-islington

@sobolevn

One week later - merging :)

@bedevere-app

sobolevn added a commit that referenced this pull request

Sep 1, 2024

@miss-islington @sobolevn

…subclass__` (GH-123342) (#123569)

gh-91126: Docs and tests for slotted dataclasses with __init_subclass__ (GH-123342) (cherry picked from commit 75e7282)

Co-authored-by: sobolevn mail@sobolevn.me

sobolevn added a commit that referenced this pull request

Sep 1, 2024

@miss-islington @sobolevn

…subclass__` (GH-123342) (#123568)

gh-91126: Docs and tests for slotted dataclasses with __init_subclass__ (GH-123342) (cherry picked from commit 75e7282)

Co-authored-by: sobolevn mail@sobolevn.me

@bedevere-bot

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 Refleaks 3.13 has failed when building commit cfdf376.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1407/builds/136) and take a look at the build logs.
  4. Check if the failure is related to this commit (cfdf376) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1407/builds/136

Failed subtests:

Summary of the results of the build (if available):

Click to see traceback logs

Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-ppc64le.refleak/build/Lib/test/test_asyncio/test_events.py", line 694, in test_create_connection_local_addr_skip_different_family with self.assertRaises(OSError): self.loop.run_until_complete(f) AssertionError: OSError not raised