[2.7] bpo-36235: Fix CFLAGS in distutils customize_compiler() (GH-12236) by vstinner · Pull Request #12349 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation0 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

vstinner

Fix CFLAGS in customize_compiler() of distutils.sysconfig: when the
CFLAGS environment variable is defined, don't override CFLAGS variable with
the OPT variable anymore.

Initial patch written by David Malcolm.

Co-Authored-By: David Malcolm dmalcolm@redhat.com
(cherry picked from commit 86082c2)

https://bugs.python.org/issue36235

@vstinner @davidmalcolm

Fix CFLAGS in customize_compiler() of distutils.sysconfig: when the CFLAGS environment variable is defined, don't override CFLAGS variable with the OPT variable anymore.

Initial patch written by David Malcolm.

Co-Authored-By: David Malcolm dmalcolm@redhat.com (cherry picked from commit 86082c2)

esc added a commit to esc/numba that referenced this pull request

Oct 30, 2019

@esc

At some point in October 2019 the Python 2.7 Builds on MacOSX started failing with the following error:

/Users/runner/miniconda3/envs/travisci/include/python2.7/Python.h:33:10: fatal error: 'stdio.h' file not found
         ^~~~~~~~~
1 error generated.

While it isn't clear where the root cause of this issue lies --- either with the Anaconda based c-compilers or with the Microsoft build image --- this patch

It is to be suspected that the following backport may be involved:

python/cpython#12349

This also means that future releases of Python may actually suffer from the same issue, so we will have to keep an eye on these.

Hopfully, this patch will no longer be required when Python 2.7 is EOL in 2020.

@esc esc mentioned this pull request

Oct 30, 2019

esc added a commit to esc/numba that referenced this pull request

Oct 30, 2019

@esc

At some point in October 2019 the Python 2.7 Builds on MacOSX started failing with the following error:

/Users/runner/miniconda3/envs/travisci/include/python2.7/Python.h:33:10: fatal error: 'stdio.h' file not found
         ^~~~~~~~~
1 error generated.

While it isn't clear where the root cause of this issue lies --- either with the Anaconda based c-compilers or with the Microsoft build image --- this patch

It is to be suspected that the following backport may be involved:

python/cpython#12349

This also means that future releases of Python may actually suffer from the same issue, so we will have to keep an eye on these.

Hopfully, this patch will no longer be required when Python 2.7 is EOL in 2020.

esc added a commit to esc/numba that referenced this pull request

Oct 30, 2019

@esc

At some point in October 2019 the Python 2.7 Builds on MacOSX started failing with the following error:

/Users/runner/miniconda3/envs/travisci/include/python2.7/Python.h:33:10: fatal error: 'stdio.h' file not found
         ^~~~~~~~~
1 error generated.

While it isn't clear where the root cause of this issue lies --- either with the Anaconda based c-compilers or with the Microsoft build image --- this patch

It is to be suspected that the following backport may be involved:

python/cpython#12349

This also means that future releases of Python may actually suffer from the same issue, so we will have to keep an eye on these.

Hopfully, this patch will no longer be required when Python 2.7 is EOL in 2020.

jua74470 pushed a commit to jua74470/python2.7 that referenced this pull request

Nov 14, 2024

@hroncok