GH-123599: Deprecate duplicate pathname2url() implementation by barneygale · Pull Request #127380 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation13 Commits5 Checks41 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Contributor
•
edited by github-actionsbot
Loading
Call urllib.request.pathname2url() from pathlib.Path.as_uri(), and
deprecate the duplicate implementation in PurePath.
Co-authored-by: Adam Turner 9087854+AA-Turner@users.noreply.github.com
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry for missing this PR initially, I only spotted it when you closed the other PR earlier today.
A
No worries, and thanks very much for the review!
Embarrassingly I actually linked the wrong PR from my comment in #123650 😅. I've edited it now.
seehwan pushed a commit to seehwan/cpython that referenced this pull request
Call urllib.request.pathname2url() from pathlib.Path.as_uri(), and
deprecate the duplicate implementation in PurePath.
Co-authored-by: Adam Turner 9087854+AA-Turner@users.noreply.github.com