[3.7] bpo-28866: No type cache for types with specialized mro, invalidation is hard. (GH-13157) by miss-islington · Pull Request #13589 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
- No type cache for types with specialized mro, invalidation is hard.
- FIX: Don't disable method cache custom types that do not implement mro().
- fixing implem.
- Avoid storing error flags, also decref.
- news entry
- Clear as soon as we're getting an error.
- FIX: Reference leak.
(cherry picked from commit 180dc1b)
Co-authored-by: Julien Palard julien@palard.fr
https://bugs.python.org/issue28866
… is hard. (pythonGH-13157)
No type cache for types with specialized mro, invalidation is hard.
FIX: Don't disable method cache custom types that do not implement mro().
fixing implem.
Avoid storing error flags, also decref.
news entry
Clear as soon as we're getting an error.
FIX: Reference leak. (cherry picked from commit 180dc1b)
Co-authored-by: Julien Palard julien@palard.fr
astrofrog added a commit to astrofrog/glue that referenced this pull request
…tsByName. The error happens following the change in python/cpython#13589. Basically it looks like connectSlotsByName causes all properties of the Qt class to be accessed, but the viewer property didn't previously work before the load_ui call since _viewer wasn't defined and an AttributeError was raised. The fix here is to make sure that self._viewer is defined before load_ui is called.
astrofrog added a commit to glue-viz/glue that referenced this pull request
…tsByName. The error happens following the change in python/cpython#13589. Basically it looks like connectSlotsByName causes all properties of the Qt class to be accessed, but the viewer property didn't previously work before the load_ui call since _viewer wasn't defined and an AttributeError was raised. The fix here is to make sure that self._viewer is defined before load_ui is called.
astrofrog added a commit to glue-viz/glue that referenced this pull request
…tsByName. The error happens following the change in python/cpython#13589. Basically it looks like connectSlotsByName causes all properties of the Qt class to be accessed, but the viewer property didn't previously work before the load_ui call since _viewer wasn't defined and an AttributeError was raised. The fix here is to make sure that self._viewer is defined before load_ui is called.
javerbukh pushed a commit to javerbukh/glue that referenced this pull request
…tsByName. The error happens following the change in python/cpython#13589. Basically it looks like connectSlotsByName causes all properties of the Qt class to be accessed, but the viewer property didn't previously work before the load_ui call since _viewer wasn't defined and an AttributeError was raised. The fix here is to make sure that self._viewer is defined before load_ui is called.
