bpo-30231: Remove skipped test_imaplib tests by vstinner · Pull Request #1419 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

vstinner

The public cyrus.andrew.cmu.edu IMAP server (port 993) doesn't accept
TLS connection using our self-signed x509 certificate. Remove the two
tests which are already skipped.

@mention-bot

@vstinner vstinner changed the titlebpo-30231: Remove skipped test_ssl tests bpo-30231: Remove skipped test_imaplib tests

May 3, 2017

berkerpeksag

with support.check_warnings(('', DeprecationWarning)):
_server = self.imap_class(self.host, self.port,
certfile=CERTFILE)
self.check_logincapa(_server)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps drop this line and only check for DeprecationWarning instead of removing the whole test (you probably can make it simpler)? It looks like the following branch is only covered by this test so keeping it might be better:

if keyfile is not None or certfile is not None: import warnings warnings.warn("keyfile and certfile are deprecated, use a" "custom ssl_context instead", DeprecationWarning, 2)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I wrote a new unit test to check for the deprecation warning.

@vstinner

The public cyrus.andrew.cmu.edu IMAP server (port 993) doesn't accept TLS connection using our self-signed x509 certificate. Remove the two tests which are already skipped.

Write a new test_certfile_arg_warn() unit test for the certfile deprecation warning.

vstinner added a commit that referenced this pull request

Jun 14, 2017

@vstinner

The public cyrus.andrew.cmu.edu IMAP server (port 993) doesn't accept TLS connection using our self-signed x509 certificate. Remove the two tests which are already skipped.

Write a new test_certfile_arg_warn() unit test for the certfile deprecation warning. (cherry picked from commit b18563d)

vstinner added a commit that referenced this pull request

Jun 14, 2017

@vstinner

The public cyrus.andrew.cmu.edu IMAP server (port 993) doesn't accept TLS connection using our self-signed x509 certificate. Remove the two tests which are already skipped.

ned-deily pushed a commit that referenced this pull request

Jul 20, 2017

@vstinner @ned-deily

…#2481)

Add .travis.yml for Travis CI.

The public cyrus.andrew.cmu.edu IMAP server (port 993) doesn't accept TLS connection using our self-signed x509 certificate. Remove the two tests which are already skipped. (cherry picked from commit 7895a05)

larryhastings pushed a commit that referenced this pull request

Jul 22, 2017

@vstinner @larryhastings

On Windows a symlink can has the FILE_ATTRIBUTE_DIRECTORY flag.

(cherry picked from commit 388b90f)

The public cyrus.andrew.cmu.edu IMAP server (port 993) doesn't accept TLS connection using our self-signed x509 certificate. Remove the two tests which are already skipped. (cherry picked from commit 7895a05)

The regen-all Makefile rule doesn't exist in Python 3.4, only since Python 3.5 and newer (and 2.7).

tzdata resource doesn't exist in Python 3.4.

Fixing Sphinx warnings requires to backport huge intrusive changes like:

Fix test_invalid_cmd() and test_invalid_env(), TypeError is raised on Python 3.4.

(cherry picked from commit 5e22721)