[3.8] bpo-32912: Revert warnings for invalid escape sequences. by serhiy-storchaka · Pull Request #15142 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits3 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
DeprecationWarning will continue to be emitted for invalid
escape sequences in string and bytes literals in 3.8.
SyntaxWarning will be emitted in 3.9.
https://bugs.python.org/issue32912
DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals in 3.8. SyntaxWarning will be emitted in 3.9.
and mention that SyntaxError will happen after SyntaxWarning. we're being non-specific on purpose here as we haven't worked out the plan to make this happen without causing end user pain yet. right now most code owners do not see the DeprecationWarning but when turned into a SyntaxWarning, users of libraries see it more often than owners. So it is a negative experience all around.
My only problem with this PR is only that it is being done on the 3.8 branch.
We should revert this on the master (future 3.9) branch as well. We clearly aren't ready to commit to doing this in 3.9 either so lets redo this on top of that and apply the "needs backport to 3.8" label.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to agree with @gpshead on applying this to master and then backporting to 3.8
merged. I'll just reapply an equivalent to master.
miss-islington pushed a commit that referenced this pull request
DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals just as it did in 3.7.
SyntaxWarning may be emitted in the future. But per mailing list discussion, we don't yet know when because we haven't settled on how to do so in a non-disruptive manner.
(Applies 4c5b6ba to the master branch). (This is #15142 for master/3.9)
https://bugs.python.org/issue32912
Automerge-Triggered-By: @gpshead
lisroach pushed a commit to lisroach/cpython that referenced this pull request
DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals just as it did in 3.7.
SyntaxWarning may be emitted in the future. But per mailing list discussion, we don't yet know when because we haven't settled on how to do so in a non-disruptive manner.
(Applies 4c5b6ba to the master branch). (This is python#15142 for master/3.9)
https://bugs.python.org/issue32912
Automerge-Triggered-By: @gpshead
DinoV pushed a commit to DinoV/cpython that referenced this pull request
DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals just as it did in 3.7.
SyntaxWarning may be emitted in the future. But per mailing list discussion, we don't yet know when because we haven't settled on how to do so in a non-disruptive manner.
(Applies 4c5b6ba to the master branch). (This is python#15142 for master/3.9)
https://bugs.python.org/issue32912
Automerge-Triggered-By: @gpshead
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request
DeprecationWarning will continue to be emitted for invalid escape sequences in string and bytes literals just as it did in 3.7.
SyntaxWarning may be emitted in the future. But per mailing list discussion, we don't yet know when because we haven't settled on how to do so in a non-disruptive manner.
(Applies 4c5b6ba to the master branch). (This is python#15142 for master/3.9)
https://bugs.python.org/issue32912
Automerge-Triggered-By: @gpshead
