bpo-18108: Adding dir_fd and follow_symlinks keyword args to shutil.chown by ta1hia · Pull Request #15811 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation19 Commits1 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
In addition to adding the kwargs, I extended the existing test_shutil.TestShutil.test_chown unit test and also added to the documentation (shutil.chown docstring and Docs/library/shutil.chown function description).
Co-Authored-By: Berker Peksang berker.peksag@gmail.com
https://bugs.python.org/issue18108
zware previously requested changes Sep 11, 2019
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor issues, but otherwise this LGTM. Adding @berkerpeksag and @vstinner as others who may be better suited to review this (as Berker wrote the original patch on the issue, and Victor added these parameters to the os functions).
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.
Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
I'm not going to review or merge this PR as my patch was taken without my approval on the issue tracker and my name wasn't even mentioned in the new PR.
I'm not going to review or merge this PR as my patch was taken without my approval on the issue tracker and my name wasn't even mentioned in the new PR.
It's true, @berkerpeksag uploaded a patch to the bug tracker for this already and I failed to check with him before submitting this PR. My apologies - I grabbed what seemed like a stale issue without following the proper protocol. I can close this PR if that's what makes the most sense at this point.
I personally think it would be OK to add a Co-Authored-By: "header" to include @berkerpeksag's authorship if he's alright with that, but I'll leave that up to him. I do note that there are significant changes here compared to Berker's original patch, though a large chunk of it is still his work.
@berkerpeksag, would you mind to either sign off on a Co-Authored-By credit or close the PR?
I left my earlier comment because I was asked to review the PR. I'll let Zachary and/or Victor decide what to do next as I have no intention to block merging this PR.
I have made the requested changes; please review again
As for adding Berker as a co-author, would it be best to do that in a new commit?
Thanks for making the requested changes!
@zware: please review the changes made to this pull request.
All commit authors signed the Contributor License Agreement.
@zware's suggestions were applied. The code was updated to the current main, I made also some minor changes. @ta1hia, please check that I wrote your name correctly in the What's New file.
@ta1hia Please click the button in #15811 (comment) to re-sign the CLA with your current GH email. It is needed to merge here.
@serhiy-storchaka, could you close this in favor of #118136? We can't merge this pull request if the CLA isn't signed.
I based mine only on the patch of Berker, so there shouldn't be any problems with licensing.
- Adding dir_fd and follow_symlinks keyword args to shutil.chown
- Extending test_shutil.TestShutil.test_chown to include new kwargs
- Updating shutil.chown documentation
Co-authored-by: Berker Peksag berker.peksag@gmail.com Co-authored-by: Tahia Khan tahia.khan@gmail.com Co-authored-by: Zachary Ware zachary.ware@gmail.com Co-authored-by: Serhiy Storchaka storchaka@gmail.com
Thank you @nineteendo, but it was not only the original patch, but some @ta1hia's additions, and suggestions from the review, and finally my changes. We do not want to lose it. I am sure that the problem with the CLA bot is technical, not legal, so we can work it around.
