bpo-38304: PyConfig_InitPythonConfig() cannot fail anymore by vstinner · Pull Request #16509 · python/cpython (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits2 Checks0 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no longer return PyStatus: they cannot fail anymore.
I forgot to update PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() in my PR #16500. There is no more need to return PyStatus since these functions cannot fail anymore. They don't allocate any memory: strings are initialized to NULL, lists to empty lists (which doesn't allocate any memory).
cc @ncoghlan @ambv That can wait for 3.8.0rc2 or 3.8.0 final if it's too late for rc1.
ambv approved these changes Oct 1, 2019
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for CI and merge.
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington added a commit that referenced this pull request
PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no longer return PyStatus: they cannot fail anymore. (cherry picked from commit 8462a49)
Co-authored-by: Victor Stinner vstinner@redhat.com
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request
PyConfig_InitPythonConfig() and PyConfig_InitIsolatedConfig() no longer return PyStatus: they cannot fail anymore.
Reviewers
