bpo-39885: IDLE: Leave selection when right click within by terryjreedy · Pull Request #18951 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits7 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

terryjreedy

@terryjreedy

This exception was omitted from previous commit, 4ca060d.

@terryjreedy

This must be changed before next releases. I may or may not change cursor handling in this patch. I will look into adding tests.

@terryjreedy

@terryjreedy

@terryjreedy

Conflicts:

Misc/NEWS.d/next/IDLE/2020-03-08-14-27-36.bpo-39885.29ERiR.rst

@miss-islington

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 29, 2020

@terryjreedy @miss-islington

…8951)

Leave selection when right click within. This exception to clearing selections when right-clicking was omitted from the previous commit, 4ca060d. I did not realize that this completely disabled the context menu entries, and I should have merged a minimal fix immediately. An automated test should follow. (cherry picked from commit 97e4e0f)

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 29, 2020

@terryjreedy @miss-islington

…8951)

Leave selection when right click within. This exception to clearing selections when right-clicking was omitted from the previous commit, 4ca060d. I did not realize that this completely disabled the context menu entries, and I should have merged a minimal fix immediately. An automated test should follow. (cherry picked from commit 97e4e0f)

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu

@bedevere-bot

miss-islington added a commit that referenced this pull request

May 29, 2020

@miss-islington @terryjreedy

Leave selection when right click within. This exception to clearing selections when right-clicking was omitted from the previous commit, 4ca060d. I did not realize that this completely disabled the context menu entries, and I should have merged a minimal fix immediately. An automated test should follow. (cherry picked from commit 97e4e0f)

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu

miss-islington added a commit that referenced this pull request

May 29, 2020

@miss-islington @terryjreedy

Leave selection when right click within. This exception to clearing selections when right-clicking was omitted from the previous commit, 4ca060d. I did not realize that this completely disabled the context menu entries, and I should have merged a minimal fix immediately. An automated test should follow. (cherry picked from commit 97e4e0f)

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu

miss-islington added a commit that referenced this pull request

May 29, 2020

@miss-islington @terryjreedy

Leave selection when right click within. This exception to clearing selections when right-clicking was omitted from the previous commit, 4ca060d. I did not realize that this completely disabled the context menu entries, and I should have merged a minimal fix immediately. An automated test should follow. (cherry picked from commit 97e4e0f)

Co-authored-by: Terry Jan Reedy tjreedy@udel.edu

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request

May 30, 2020

@CuriousLearner

Labels

type-bug

An unexpected behavior, bug, or error