bpo-39573: Convert Py_TYPE() to a static inline function by corona10 · Pull Request #20290 · python/cpython (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation12 Commits6 Checks0 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I was waiting for Python 3.10 to do this change.

cc @nascheme

Co-authored-by: Victor Stinner vstinner@python.org

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. My comments about "const" can be addressed in a separated PR.

tacaswell added a commit to tacaswell/numpy that referenced this pull request

May 29, 2020

In python/cpython#20290 CPython changed Py_TYPE from a macro to an inline function. This requires a code change to us Py_SET_TYPE instead when using Py_TYPE() as a lvalue in c code.

In python/cpython#20429 CPython changed Py_SIZE from a macro to an inline function. This requires a code change to us Py_SET_SIZE instead of using Py_SIZE as a lvalue in c code.

tacaswell added a commit to tacaswell/pycurl that referenced this pull request

May 29, 2020

There was a change in the CPython c-api to change Py_TYPE from a macro to an inline function (python/cpython#20290). This requires a change to using Py_SET_TYPE which was introduced on py39a4.

charris pushed a commit to charris/numpy that referenced this pull request

May 29, 2020

In python/cpython#20290 CPython changed Py_TYPE from a macro to an inline function. This requires a code change to us Py_SET_TYPE instead when using Py_TYPE() as a lvalue in c code.

In python/cpython#20429 CPython changed Py_SIZE from a macro to an inline function. This requires a code change to us Py_SET_SIZE instead of using Py_SIZE as a lvalue in c code.

cielavenir pushed a commit to cielavenir/numpy that referenced this pull request

Aug 9, 2023

In python/cpython#20290 CPython changed Py_TYPE from a macro to an inline function. This requires a code change to us Py_SET_TYPE instead when using Py_TYPE() as a lvalue in c code.

In python/cpython#20429 CPython changed Py_SIZE from a macro to an inline function. This requires a code change to us Py_SET_SIZE instead of using Py_SIZE as a lvalue in c code.

cielavenir pushed a commit to cielavenir/numpy that referenced this pull request

Aug 22, 2023

In python/cpython#20290 CPython changed Py_TYPE from a macro to an inline function. This requires a code change to us Py_SET_TYPE instead when using Py_TYPE() as a lvalue in c code.

In python/cpython#20429 CPython changed Py_SIZE from a macro to an inline function. This requires a code change to us Py_SET_SIZE instead of using Py_SIZE as a lvalue in c code.